Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General update and refresh on front page #12

Merged
merged 3 commits into from
Oct 22, 2024
Merged

General update and refresh on front page #12

merged 3 commits into from
Oct 22, 2024

Conversation

graeme-a-stewart
Copy link
Member

Add logo
Reorganise materials

Add logo
Reorganise materials
Copy link

Preview should be up in a couple of mins at
https://www.juliahep.org/previews/PR12
(if you get a 404, wait 30s then refresh).

@Moelf
Copy link
Member

Moelf commented Oct 22, 2024

I don't see the logo rendered

Copy link

Preview should be up in a couple of mins at
https://www.juliahep.org/previews/PR12
(if you get a 404, wait 30s then refresh).

@graeme-a-stewart
Copy link
Member Author

Weird - I get it locally... I'm checking

Probably this is what's breaking the preview, which is not deployed into the website root
Copy link

Preview should be up in a couple of mins at
https://www.juliahep.org/previews/PR12
(if you get a 404, wait 30s then refresh).

@graeme-a-stewart
Copy link
Member Author

OK, fixed! I had used an absolute URL for the image, which doesn't work with a preview that lives outside the website root. Now it's relative.

@Moelf Moelf merged commit 26a6d61 into main Oct 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants