Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RNTuple] support more types in RNTuple writing #348

Merged
merged 4 commits into from
Sep 27, 2024

Conversation

Moelf
Copy link
Member

@Moelf Moelf commented Sep 27, 2024

support writing a single, not too long column of type:

julia> [Float64, Float32, Float16, Int64, Int32, Int16, Int8, UInt64, UInt32, UInt16]

Further reduce amount of hard-coding in writing logic

@Moelf Moelf changed the title support more types in RNTuple writing [RNTuple] support more types in RNTuple writing Sep 27, 2024
Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 83.67347% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.90%. Comparing base (8a28452) to head (1fe82b1).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/RNTuple/Writing/page_writing.jl 76.47% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #348      +/-   ##
==========================================
+ Coverage   84.79%   84.90%   +0.10%     
==========================================
  Files          20       21       +1     
  Lines        2967     2994      +27     
==========================================
+ Hits         2516     2542      +26     
- Misses        451      452       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Moelf Moelf merged commit 0679f73 into main Sep 27, 2024
9 of 10 checks passed
@Moelf Moelf deleted the rntuple_writing_more_types branch September 27, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant