Replacing xrootdgo by XRootD #340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #340 +/- ##
==========================================
+ Coverage 84.16% 84.23% +0.07%
==========================================
Files 19 19
Lines 2564 2557 -7
==========================================
- Hits 2158 2154 -4
+ Misses 406 403 -3 ☔ View full report in Codecov by Sentry. |
peremato
changed the title
Moelf
approved these changes
Jun 3, 2024
Moelf
pushed a commit
that referenced
this pull request
Jun 18, 2024
* Replace xrootdgo_jll by XRootD.jl
Moelf
reviewed
Jul 1, 2024
| @@ -4,27 +4,29 @@ using UnROOT | |||
| nthreads = UnROOT._maxthreadid() | |||
| nthreads == 1 && @warn "Running on a single thread. Please re-run the test suite with at least two threads (`julia --threads 2 ...`)" | |||
|
|
|||
| include("Aqua.jl") | |||
There was a problem hiding this comment.
this change has made tests printing delayed until something goes wrong, feels a bit annoying
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapted to use the recently developed wrapper XRootD.jl to native XRootD libraries.