Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to FHist 0.11 series #9

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

graeme-a-stewart
Copy link
Member

This adapts to the FHist 0.11 API, that defines binedges, rather than bins.

N.B. this means losing compatibility with FHist = "0.10".

Tests are running ok, but I don't know if the histograms are exercised fully.

Fixes #8.

This adapts to the FHist 0.11 API, that defines binedges, rather than bins
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.77%. Comparing base (cb13d03) to head (284da1b).

Files with missing lines Patch % Lines
src/Histograms.jl 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main       #9   +/-   ##
=======================================
  Coverage   77.77%   77.77%           
=======================================
  Files           7        7           
  Lines         477      477           
=======================================
  Hits          371      371           
  Misses        106      106           
Flag Coverage Δ
?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@peremato
Copy link
Member

Thanks for the changes!

@peremato peremato merged commit 86f2403 into JuliaHEP:main Oct 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compatibility with FHist 0.11?
3 participants