Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document differences from GeoJSON #30

Merged
merged 1 commit into from
Feb 6, 2021
Merged

Document differences from GeoJSON #30

merged 1 commit into from
Feb 6, 2021

Conversation

cmcaine
Copy link
Contributor

@cmcaine cmcaine commented Feb 5, 2021

No description provided.

@cmcaine
Copy link
Contributor Author

cmcaine commented Feb 5, 2021

I wonder if GeoJSON.jl should also warn or error if it would overwrite existing properties when doing these transformations. I think it should.

@yeesian yeesian merged commit a869bcd into JuliaGeo:master Feb 6, 2021
@yeesian yeesian mentioned this pull request Feb 6, 2021
Open
@yeesian
Copy link
Member

yeesian commented Feb 6, 2021

These are important details which I failed to document when I first implemented it, thank you so much for this!

I wonder if GeoJSON.jl should also warn or error if it would overwrite existing properties when doing these transformations. I think it should.

That's a valid consideration -- I've opened #31 for discussion, but didn't want that discussion to block this PR in the meantime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmcaine @yeesian