Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify safelog to not use __init__ #113

Merged
merged 1 commit into from
Nov 21, 2024
Merged

simplify safelog to not use __init__ #113

merged 1 commit into from
Nov 21, 2024

Conversation

Krastanov
Copy link
Member

Fixes #110

@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.38%. Comparing base (c74f325) to head (49c4a50).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/safe_logging.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #113      +/-   ##
==========================================
- Coverage   79.44%   79.38%   -0.07%     
==========================================
  Files           6        6              
  Lines         681      679       -2     
==========================================
- Hits          541      539       -2     
  Misses        140      140              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link

Benchmark Result

Judge result

Benchmark Report for /home/runner/work/ResumableFunctions.jl/ResumableFunctions.jl

Job Properties

  • Time of benchmarks:
  • Target: 21 Nov 2024 - 17:39
  • Baseline: 21 Nov 2024 - 17:40
  • Package commits:
  • Target: bfde31
  • Baseline: c74f32
  • Julia commits:
  • Target: 67dffc
  • Baseline: 67dffc
  • Julia command flags:
  • Target: None
  • Baseline: None
  • Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID time ratio memory ratio
["hardcoded types", "BigInt", "Closure"] 1.19 (5%) ❌ 1.00 (1%)
["hardcoded types", "Int64", "Closure statemachine"] 1.83 (5%) ❌ 1.00 (1%)
["hardcoded types", "Int64", "Closure"] 1.22 (5%) ❌ 1.00 (1%)
["hardcoded types", "Int64", "Iteration protocol"] 0.55 (5%) ✅ 1.00 (1%)
["hardcoded types", "Int64", "ResumableFunctions"] 0.54 (5%) ✅ 1.00 (1%)

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["hardcoded types", "BigInt"]
  • ["hardcoded types", "Int64"]

Julia versioninfo

Target

Julia Version 1.10.6
Commit 67dffc4a8ae (2024-10-28 12:23 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.5 LTS
 uname: Linux 6.5.0-1025-azure #26~22.04.1-Ubuntu SMP Thu Jul 11 22:33:04 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3240 MHz 273 s 0 s 71 s 2258 s 0 s
 #2 3243 MHz 436 s 0 s 72 s 2089 s 0 s
 #3 2445 MHz 544 s 0 s 139 s 1914 s 0 s
 #4 3186 MHz 743 s 0 s 200 s 1650 s 0 s
 Memory: 15.606487274169922 GB (14091.98828125 MB free)
 Uptime: 262.38 sec
 Load Avg: 1.08 0.61 0.25
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline

Julia Version 1.10.6
Commit 67dffc4a8ae (2024-10-28 12:23 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.5 LTS
 uname: Linux 6.5.0-1025-azure #26~22.04.1-Ubuntu SMP Thu Jul 11 22:33:04 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 2445 MHz 424 s 0 s 84 s 2494 s 0 s
 #2 2445 MHz 490 s 0 s 76 s 2433 s 0 s
 #3 3233 MHz 672 s 0 s 171 s 2156 s 0 s
 #4 3240 MHz 771 s 0 s 205 s 2019 s 0 s
 Memory: 15.606487274169922 GB (14097.87890625 MB free)
 Uptime: 302.6 sec
 Load Avg: 1.04 0.66 0.29
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Target result

Benchmark Report for /home/runner/work/ResumableFunctions.jl/ResumableFunctions.jl

Job Properties

  • Time of benchmark: 21 Nov 2024 - 17:39
  • Package commit: bfde31
  • Julia commit: 67dffc
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["hardcoded types", "BigInt", "Channels csize=0"] 193.581 μs (5%) 7.27 KiB (1%) 302
["hardcoded types", "BigInt", "Channels csize=1"] 202.258 μs (5%) 7.31 KiB (1%) 302
["hardcoded types", "BigInt", "Channels csize=100"] 59.050 μs (5%) 9.09 KiB (1%) 304
["hardcoded types", "BigInt", "Channels csize=20"] 65.893 μs (5%) 7.64 KiB (1%) 303
["hardcoded types", "BigInt", "Closure optimized"] 3.671 μs (5%) 4.47 KiB (1%) 192
["hardcoded types", "BigInt", "Closure statemachine"] 4.192 μs (5%) 4.53 KiB (1%) 195
["hardcoded types", "BigInt", "Closure"] 5.273 μs (5%) 4.47 KiB (1%) 192
["hardcoded types", "BigInt", "Direct"] 3.477 μs (5%) 4.39 KiB (1%) 188
["hardcoded types", "BigInt", "Iteration protocol"] 3.513 μs (5%) 4.48 KiB (1%) 191
["hardcoded types", "BigInt", "ResumableFunctions"] 3.951 μs (5%) 4.52 KiB (1%) 191
["hardcoded types", "BigInt", "Task scheduling"] 28.613 μs (5%) 5.27 KiB (1%) 197
["hardcoded types", "Int64", "Channels csize=0"] 185.656 μs (5%) 2.61 KiB (1%) 97
["hardcoded types", "Int64", "Channels csize=1"] 190.435 μs (5%) 1.44 KiB (1%) 19
["hardcoded types", "Int64", "Channels csize=100"] 54.913 μs (5%) 3.22 KiB (1%) 21
["hardcoded types", "Int64", "Channels csize=20"] 61.164 μs (5%) 1.77 KiB (1%) 20
["hardcoded types", "Int64", "Closure optimized"] 17.537 ns (5%)
["hardcoded types", "Int64", "Closure statemachine"] 61.991 ns (5%)
["hardcoded types", "Int64", "Closure"] 2.548 μs (5%) 1.28 KiB (1%) 82
["hardcoded types", "Int64", "Direct"] 18.198 ns (5%)
["hardcoded types", "Int64", "Iteration protocol"] 33.627 ns (5%)
["hardcoded types", "Int64", "ResumableFunctions"] 33.627 ns (5%)
["hardcoded types", "Int64", "Task scheduling"] 17.803 μs (5%) 2.05 KiB (1%) 85

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["hardcoded types", "BigInt"]
  • ["hardcoded types", "Int64"]

Julia versioninfo

Julia Version 1.10.6
Commit 67dffc4a8ae (2024-10-28 12:23 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.5 LTS
 uname: Linux 6.5.0-1025-azure #26~22.04.1-Ubuntu SMP Thu Jul 11 22:33:04 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 3240 MHz 273 s 0 s 71 s 2258 s 0 s
 #2 3243 MHz 436 s 0 s 72 s 2089 s 0 s
 #3 2445 MHz 544 s 0 s 139 s 1914 s 0 s
 #4 3186 MHz 743 s 0 s 200 s 1650 s 0 s
 Memory: 15.606487274169922 GB (14091.98828125 MB free)
 Uptime: 262.38 sec
 Load Avg: 1.08 0.61 0.25
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline result

Benchmark Report for /home/runner/work/ResumableFunctions.jl/ResumableFunctions.jl

Job Properties

  • Time of benchmark: 21 Nov 2024 - 17:40
  • Package commit: c74f32
  • Julia commit: 67dffc
  • Julia command flags: None
  • Environment variables: None

Results

Below is a table of this job's results, obtained by running the benchmarks.
The values listed in the ID column have the structure [parent_group, child_group, ..., key], and can be used to
index into the BaseBenchmarks suite to retrieve the corresponding benchmarks.
The percentages accompanying time and memory values in the below table are noise tolerances. The "true"
time/memory value for a given benchmark is expected to fall within this percentage of the reported value.
An empty cell means that the value was zero.

ID time GC time memory allocations
["hardcoded types", "BigInt", "Channels csize=0"] 195.585 μs (5%) 7.27 KiB (1%) 302
["hardcoded types", "BigInt", "Channels csize=1"] 201.145 μs (5%) 7.31 KiB (1%) 302
["hardcoded types", "BigInt", "Channels csize=100"] 58.840 μs (5%) 9.09 KiB (1%) 304
["hardcoded types", "BigInt", "Channels csize=20"] 65.923 μs (5%) 7.64 KiB (1%) 303
["hardcoded types", "BigInt", "Closure optimized"] 3.664 μs (5%) 4.47 KiB (1%) 192
["hardcoded types", "BigInt", "Closure statemachine"] 4.192 μs (5%) 4.53 KiB (1%) 195
["hardcoded types", "BigInt", "Closure"] 4.420 μs (5%) 4.47 KiB (1%) 192
["hardcoded types", "BigInt", "Direct"] 3.465 μs (5%) 4.39 KiB (1%) 188
["hardcoded types", "BigInt", "Iteration protocol"] 3.512 μs (5%) 4.48 KiB (1%) 191
["hardcoded types", "BigInt", "ResumableFunctions"] 3.937 μs (5%) 4.52 KiB (1%) 191
["hardcoded types", "BigInt", "Task scheduling"] 28.273 μs (5%) 5.27 KiB (1%) 197
["hardcoded types", "Int64", "Channels csize=0"] 185.126 μs (5%) 2.61 KiB (1%) 97
["hardcoded types", "Int64", "Channels csize=1"] 191.147 μs (5%) 1.44 KiB (1%) 19
["hardcoded types", "Int64", "Channels csize=100"] 54.923 μs (5%) 3.22 KiB (1%) 21
["hardcoded types", "Int64", "Channels csize=20"] 61.275 μs (5%) 1.77 KiB (1%) 20
["hardcoded types", "Int64", "Closure optimized"] 17.989 ns (5%)
["hardcoded types", "Int64", "Closure statemachine"] 33.936 ns (5%)
["hardcoded types", "Int64", "Closure"] 2.083 μs (5%) 1.28 KiB (1%) 82
["hardcoded types", "Int64", "Direct"] 18.198 ns (5%)
["hardcoded types", "Int64", "Iteration protocol"] 61.676 ns (5%)
["hardcoded types", "Int64", "ResumableFunctions"] 61.978 ns (5%)
["hardcoded types", "Int64", "Task scheduling"] 17.884 μs (5%) 2.05 KiB (1%) 85

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

  • ["hardcoded types", "BigInt"]
  • ["hardcoded types", "Int64"]

Julia versioninfo

Julia Version 1.10.6
Commit 67dffc4a8ae (2024-10-28 12:23 UTC)
Build Info:
 Official https://julialang.org/ release
Platform Info:
 OS: Linux (x86_64-linux-gnu)
 Ubuntu 22.04.5 LTS
 uname: Linux 6.5.0-1025-azure #26~22.04.1-Ubuntu SMP Thu Jul 11 22:33:04 UTC 2024 x86_64 x86_64
 CPU: AMD EPYC 7763 64-Core Processor: 
 speed user nice sys idle irq
 #1 2445 MHz 424 s 0 s 84 s 2494 s 0 s
 #2 2445 MHz 490 s 0 s 76 s 2433 s 0 s
 #3 3233 MHz 672 s 0 s 171 s 2156 s 0 s
 #4 3240 MHz 771 s 0 s 205 s 2019 s 0 s
 Memory: 15.606487274169922 GB (14097.87890625 MB free)
 Uptime: 302.6 sec
 Load Avg: 1.04 0.66 0.29
 WORD_SIZE: 64
 LIBM: libopenlibm
 LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Runtime information

Runtime Info
BLAS #threads 2
BLAS.vendor() lbt
Sys.CPU_THREADS 4

lscpu output:

Architecture: x86_64
CPU op-mode(s): 32-bit, 64-bit
Address sizes: 48 bits physical, 48 bits virtual
Byte Order: Little Endian
CPU(s): 4
On-line CPU(s) list: 0-3
Vendor ID: AuthenticAMD
Model name: AMD EPYC 7763 64-Core Processor
CPU family: 25
Model: 1
Thread(s) per core: 2
Core(s) per socket: 2
Socket(s): 1
Stepping: 1
BogoMIPS: 4890.85
Flags: fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ht syscall nx mmxext fxsr_opt pdpe1gb rdtscp lm constant_tsc rep_good nopl tsc_reliable nonstop_tsc cpuid extd_apicid aperfmperf pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm cmp_legacy svm cr8_legacy abm sse4a misalignsse 3dnowprefetch osvw topoext invpcid_single vmmcall fsgsbase bmi1 avx2 smep bmi2 erms invpcid rdseed adx smap clflushopt clwb sha_ni xsaveopt xsavec xgetbv1 xsaves clzero xsaveerptr rdpru arat npt nrip_save tsc_scale vmcb_clean flushbyasid decodeassists pausefilter pfthreshold v_vmsave_vmload umip vaes vpclmulqdq rdpid fsrm
Virtualization: AMD-V
Hypervisor vendor: Microsoft
Virtualization type: full
L1d cache: 64 KiB (2 instances)
L1i cache: 64 KiB (2 instances)
L2 cache: 1 MiB (2 instances)
L3 cache: 32 MiB (1 instance)
NUMA node(s): 1
NUMA node0 CPU(s): 0-3
Vulnerability Gather data sampling: Not affected
Vulnerability Itlb multihit: Not affected
Vulnerability L1tf: Not affected
Vulnerability Mds: Not affected
Vulnerability Meltdown: Not affected
Vulnerability Mmio stale data: Not affected
Vulnerability Retbleed: Not affected
Vulnerability Spec rstack overflow: Vulnerable: Safe RET, no microcode
Vulnerability Spec store bypass: Vulnerable
Vulnerability Spectre v1: Mitigation; usercopy/swapgs barriers and __user pointer sanitization
Vulnerability Spectre v2: Mitigation; Retpolines; STIBP disabled; RSB filling; PBRSB-eIBRS Not affected; BHI Not affected
Vulnerability Srbds: Not affected
Vulnerability Tsx async abort: Not affected

Cpu Property Value
Brand AMD EPYC 7763 64-Core Processor
Vendor :AMD
Architecture :Unknown
Model Family: 0xaf, Model: 0x01, Stepping: 0x01, Type: 0x00
Cores 16 physical cores, 16 logical cores (on executing CPU)
No Hyperthreading hardware capability detected
Clock Frequencies Not supported by CPU
Data Cache Level 1:3 : (32, 512, 32768) kbytes
64 byte cache line size
Address Size 48 bits virtual, 48 bits physical
SIMD 256 bit = 32 byte max. SIMD vector size
Time Stamp Counter TSC is accessible via rdtsc
TSC runs at constant rate (invariant from clock frequency)
Perf. Monitoring Performance Monitoring Counters (PMC) are not supported
Hypervisor Yes, Microsoft

@Krastanov Krastanov merged commit 3b187f7 into master Nov 21, 2024
18 of 20 checks passed
@Krastanov Krastanov deleted the simplesafelog branch November 21, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The __init__ function is not compatible with static compilation
2 participants