-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Priority as number #90
Merged
Merged
Changes from 21 commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
6d46c77
Update base.jl
hdavid16 59d237d
Update events.jl
hdavid16 f0303d9
Update containers.jl
hdavid16 d8e1320
Update stores.jl
hdavid16 ba6f5ea
Update simulations.jl
hdavid16 2efeae2
Update time.jl
hdavid16 7913399
Update test_resources_containers.jl
hdavid16 485d520
update max priority to `Inf`
hdavid16 a4df1e6
Update max priority to `Inf`
hdavid16 c19c4f6
Update max priority to `Inf`
hdavid16 fae28d5
Update base.jl
hdavid16 deb26f2
Update base.jl
hdavid16 b60be22
Update base.jl
hdavid16 4f98ac3
Update base.jl
hdavid16 61f0693
Update base.jl
hdavid16 e02cda2
user parametric type
hdavid16 c3ba26d
Update stores.jl
hdavid16 1123ccc
use parametric type
hdavid16 d9e16cc
use parametric type
hdavid16 aa10136
fix struct internal function
hdavid16 a292a9c
remove `new` call in StorePutKey
hdavid16 baa80b4
allow priorities to be Number in Containers and Stores.
hdavid16 b21674b
make parameter type order consistent btw resources
hdavid16 3b46b15
Merge branch 'master' into priority_as_number
Krastanov cac0fc1
fixup merge
Krastanov 32fccd3
fixup merge
Krastanov cedae0b
add tests for resources with different priorities
hdavid16 54238ec
allow put! and get to pass objects of different priority type
hdavid16 136aecf
remove type signatures from kwargs in resources
hdavid16 944135a
fixup
Krastanov fbbc732
fixup
Krastanov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems a lot of these type restriction can simply be dropped. Types in function signatures are used only for dispatch, they do not provide performance improvements. And it seems types in kwargs do not even participate in dispatch (see https://discourse.julialang.org/t/force-specialization-on-kwargs/34789/14 ). So this makes types for kwargs (and in particular abstract types) not particularly valuable. In most of these situations (function signatures) you can just delete the
::Int
, no need to add::Number
.