-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update examples to v6 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
That's okay, we anyways have some time to wrap up v6. I have to do the Gillespie PR. |
* Add exportable models to the package * Add compat for dependencies needed to register the package * comment out including statements to be able to release * Revert de-including the examples (#30) * Add Agents as dep * Bump version to 0.1.1 * download still unreleased Agents version manually * Remove Agents from Project.toml * Revert last commits * Pin Agent version to 6
Everything now works locally |
Apart from some errors due to that bug I fixed in the PR I opened in Agents, there are some ┌ Error: Cannot resolve @ref for '@agent' in src/examples/runners.md.
│ - no doc found for reference '[`@agent`](@ref)' in src/examples/runners.md.
│ node =
│ @ast MarkdownAST.Link("@ref", "") do
│ MarkdownAST.Code("@agent")
│ end
│
└ @ Documenter ~/.julia/packages/Documenter/2OZOh/src/utilities/utilities.jl:44 for many reference to Agents functions, do you maybe know how to resolve them @Datseris ? |
everythings works!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21 , Closes #22, Closes #13
There is still probably something to do, and I still didn't run the examples locally so surely there are some mistakes