Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow bode and bodeplot to use a range of frequencies and a freq to calculate the freq. vector #913

Closed
wants to merge 1 commit into from

Conversation

VaiTon
Copy link

@VaiTon VaiTon commented Jan 11, 2024

  • Added docs
  • Added tests

@baggepinnen
Copy link
Member

Hello and thank you for your PR! A few general comments to start off with

  • Please consider submitting PRs without running a formatter. on the whole file. The formatter makes lots of changes that are unrelated to the PR which makes it hard to see what you have actually changed in the PR, and I also generally do not like the changes the formatter does, hence it's not being used on this repo.
  • Please consider opening an issue before submitting a PR so that we can discuss whether or not the idea is worthwhile pursuing. In this case, we already have a PR that attempts to do something similar, but it takes a much wider approach applying to all frequency-response functions rather than just Bode: WIP: Adaptive sampling #532

@VaiTon VaiTon closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants