Use atomic_pointer* methods when available

[jpsamaroo]

Todo:

• Add modify! implementation

[codecov]

Codecov Report

Attention: Patch coverage is 47.36842% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 81.66%. Comparing base (934c34d) to head (0953048).

Files	Patch %	Lines
src/core.jl	47.36%	10 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           master      #14       +/-   ##
===========================================
- Coverage   98.00%   81.66%   -16.34%     
===========================================
  Files           4        4               
  Lines          50       60       +10     
===========================================
  Hits           49       49               
- Misses          1       11       +10     

Flag	Coverage Δ
unittests	81.66% <47.36%> (-16.34%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[willow-ahrens]

I'm curious, on my machine I'm noticing that the llvm approach is faster than the atomic_pointermodify approach. Is this expected? Do you plan to continue using this package as Julia begins to provide more atomic operations?

[vchuravy]

I'm curious, on my machine I'm noticing that the llvm approach is faster than the atomic_pointermodify approach. Is this expected? Do you plan to continue using this package as Julia begins to provide more atomic operations?

That isn't expected... Do you have a MWE?

[vchuravy]

I'm curious, on my machine I'm noticing that the llvm approach is faster than the atomic_pointermodify approach. Is this expected? Do you plan to continue using this package as Julia begins to provide more atomic operations?

Actually it is expected, this PR got never merged :/

JuliaLang/julia#45122

[willow-ahrens]

Ah, that's unfortunate! It would be great if Julia had better support for atomic increment. Do we know if anything is planned for future versions?

[vchuravy]

Do we know if anything is planned for future versions?

I will try to find some time to update the old PR.

[jpsamaroo]

Thanks for getting this fixed up and merged! ❤️

[willow-ahrens]

Yes, thanks! I'm currently working on parallelizing Finch and this package has been integral to getting the peak performance.