Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve replacement between tokens #5

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Improve replacement between tokens #5

merged 5 commits into from
Nov 21, 2024

Conversation

Johnsoct
Copy link
Owner

@Johnsoct Johnsoct commented Nov 21, 2024

  • SRP
  • Open/Closed (open for extension, closed for modification)
  • Liskov Substitution (Subtypes should be substitutable for their base types)
  • Interface Segragation (Client should not be forced to depend on interfaces it doesn't use)
  • Dependency Inversion (high-level modules should not depend on low-level modules, but both should depend on abstractions (middleman)

@Johnsoct
Copy link
Owner Author

I don't really love that the regex's are hardcoded as the key, and the submatch regex is an identical piece of the regex, but for right now, I think it's fine to leave it simple vs further abstracted.

@Johnsoct Johnsoct merged commit b9c2b33 into main Nov 21, 2024
1 check passed
@Johnsoct Johnsoct deleted the token-replace-impr branch November 21, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant