Move session from init to api #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move session from __init__ to api and into WellbeingApiClient to fetch from hass-object when needed instead of written info WellbeingApiClient on init. Might fix the intermittent errors on fetching data.
|
This is a test to fix #78 hopefully. |
JohNan
reviewed
Feb 11, 2024
custom_components/wellbeing/api.py
Outdated
| self._access_token = None | ||
| self._token = None | ||
| self.hass = hass |
There was a problem hiding this comment.
Is there a reason to not make self.hass private?
There was a problem hiding this comment.
No, that is a good idea. It should be private
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move session from init to api and into WellbeingApiClient to fetch from hass-object when needed instead of written info WellbeingApiClient on init. Might fix the intermittent errors on fetching data.
The changes in whitespace are due to VSCode cleaning =)