multi: error if restore seed/pubkey already exists for decred wallet #15
Conversation
Use a mock libwallet for now.
…ios and macos (cake-tech#1240) * change cw_decred from package to plugin * add libdcrwallet dependency and link library for android, ios and macos * remove spvwallet, make some libdcrwallet fns async, light refactor * libdcrwallet: use json payload returns * use specific libwallet commit hash * decred: fix Rename wallet. --------- Co-authored-by: JoeGruff <[email protected]>
This allows a persistent peer to be unset, falling back to decred seeders.
…cos project.pbxproj Signed-off-by: Philemon Ukane <[email protected]>
- move hasRescan method to WalletBase and implement for decred Signed-off-by: Philemon Ukane <[email protected]>
Signed-off-by: Philemon Ukane <[email protected]>
Signed-off-by: Philemon Ukane <[email protected]>
Signed-off-by: Philemon Ukane <[email protected]>
Signed-off-by: Philemon Ukane <[email protected]>
|
TODO: Update |
ukane-philemon
force-pushed
the
prevent-dup-wallets
branch
from
51d4ff3 to
1b00774
Compare
cw_decred/lib/wallet_service.dart
Outdated
| final w = await openWallet(walletName, walletPassword); | ||
| return credentials.pubkey == w.pubkey; |
There was a problem hiding this comment.
Should we close the wallet afterwards?
There was a problem hiding this comment.
We risk closing a currently used or previously loaded wallet. IMO, it doesn't hurt to have all decred wallets loaded(in libwallet).
By the time users need them in cake, it wouldn't be an issue.
There was a problem hiding this comment.
Or, better still, we could extend the implementation method to libwallet, which can be reused in other projects. That way we can close the wallets we know were not previously loaded in libwallet.
There was a problem hiding this comment.
I'm not really a fan of the map in the first place. I would like to close the wallet yeah. Also don't want to make any huge changes to libwallet when it seems to be working well atm. Let me think...
There was a problem hiding this comment.
Looking around, it doesn't look like they ever close wallets. So maybe it's fine...
Could you leave a message "TODO: Consider closing wallets."? And we will not worry about it for now.
I've noticed something wonky with that confirmation screen(on mac). If you click okay, it takes the user back to the previous screen but remains on the screen until user clicks outside the modal. Let me know if you want me to look into it. The correct behaviour is to hide the modal once the use clicks ok. |
If it's their bug then don't worry about it. Can you just add the close wallet TODO message for me? Then I think this is good. Still thinking about the libwallet changes but I think this pr is fine without them. |
Signed-off-by: Philemon Ukane <[email protected]>
ukane-philemon
force-pushed
the
prevent-dup-wallets
branch
from
1b00774 to
4e63fed
Compare
|
Thanks! Added to the main pr and testing pr. |
Issue Number (if Applicable): Fixes #
Description
Check and error if user attempts to create wallet with existing seed/xpub key.
Pull Request - Checklist