Cleanup seedfrom #14
Draft
Cleanup seedfrom #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The query planning for property paths such as sequences or alternatives was not tested. This commit adds tests for the missing cases of property path: sequence, alternative and inverse.
Prior to this change, the logic of the seedFromPropertyPath function was split over multiple functions. It also used a lot of shared_ptrs, which are unnecessary in this case. This change moves functions such as `seedFromAlternative` to the `seedFromPropertyPath` function. The logic for alternatives, sequences and so on will be moved in a future commit. Having it in a single place instead of multiple functions makes this easier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.