Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OC-997: Bring pubrouter lambda into serverless deployment #756

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Conversation

finlay-jisc
Copy link
Collaborator

The purpose of this PR was to make the pubrouter function easier to develop with by moving it in with the rest of the API code, while it had previously lived with the terraform code.

This also allowed us to have a local "version" of the function, triggered by hitting the API instead of by an S3 create event.

For the most part the function code hasn't changed, except:

  • it now lives in the api/components/pubRouter directory
  • it has had some typing added to it
  • there is some conditional logic for dealing with incoming params from a local API invocation
  • the more "controllery" logic has been put in the controller file whereas previously it was all one function

Acceptance Criteria:

  • The pubrouter function is part of the API codebase
  • It still works as it did previously on deployed environments

Checklist:

  • Local manual testing conducted
  • Automated tests added
  • Documentation updated

Tests:

API
Screenshot 2025-01-23 110143

E2E
Screenshot 2025-01-23 114405

@finlay-jisc finlay-jisc requested a review from a team as a code owner January 23, 2025 11:58
Copy link

@adwearing-jisc adwearing-jisc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely stuff

@finlay-jisc finlay-jisc merged commit 0953607 into main Jan 30, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants