do not load fonts for the UI from the internet #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jab
reviewed
Apr 15, 2018
| bannerDiv.innerHTML = ` | ||
| <link href="https://fonts.googleapis.com/css?family=Roboto:300,400,500" rel="stylesheet"> | ||
| <link href="outline://web_app/bower_components/font-roboto/roboto.html" rel="stylesheet"> |
There was a problem hiding this comment.
Now that an html include is being used instead of a CSS stylesheet, I think this should be rel="import" and not rel="stylesheet"? Maybe the webview does the right thing anyway, but still seems worth changing?
There was a problem hiding this comment.
Good catch. Changed to import.
There was a problem hiding this comment.
Seems like the change to import didn't make it through?
trevj
force-pushed
the
trevj-font-roboto-local
branch
from
e0be684 to
b527dd0
Compare
|
@alalamav PTAL, I tested (better) and replaced the logo with an SVG supplied by UX. |
alalamav
reviewed
Apr 16, 2018
| bannerDiv.innerHTML = ` | ||
| <link href="https://fonts.googleapis.com/css?family=Roboto:300,400,500" rel="stylesheet"> | ||
| <link href="outline://web_app/bower_components/font-roboto/roboto.html" rel="stylesheet"> |
There was a problem hiding this comment.
Seems like the change to import didn't make it through?
|
@alalamav Apologies, all changes now pushed. |
thatruth16
approved these changes
Apr 21, 2018
trevj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses:
#67 (comment)
From eyeballing it on my macOS laptop, the app looks identical before and after this change.