built-in-button #1389
built-in-button #1389
Conversation
There was a problem hiding this comment.
Light and dark mode screenshots show different states.
Is it expected?
| @@ -350,7 +350,7 @@ | |||
| </table> | |||
| </chapter> | |||
| <chapter title="Cancel" id="cancel"> | |||
| <table style="none" column-width="fixed"> | |||
| <table style="none" border="false" column-width="fixed"> | |||
There was a problem hiding this comment.
Could you please stick to the same order in elements? It will be easier to scan if any edits are needed.
I mean that the border attribute in lines 316, 335, 389 are last, but in 353 and 416 are not last.
|
I tried to test it locally, and borders are still present. I updated the |
MariannaKononenko
requested review from
eldar-jetbrains and
WildSeaTurtle
and removed request for
eldar-jetbrains and
WildSeaTurtle
MariannaKononenko
requested review from
OlyaB
and removed request for
eldar-jetbrains
|
|
||
| ### Browse | ||
| The **Browse** button shows a dialog for opening files from the disk, a tree view, or a table of values. | ||
| Use the **Browse** icon to select a single file or a folder from the disc. |
There was a problem hiding this comment.
- Let's remove this part: ", a tree view, or a table of values". I don't remember why we have this. For a tree or table, we have the "List values" case below.
- Seems like the second sentence has very similar meaning to the first, if the part from my point 1 is removed. Possibly these parts could be combined?
|
|
||
| ### List values | ||
|
|
||
| Use a control with the table icon to select from the list of classes, methods or environment variables: | ||
| Use the **List** icon to select a value from the list of classes, methods, or environment variables: |
There was a problem hiding this comment.
Let's make it not just classes, methods, and variables, but any object except for files from disc. Classes, methods and variables could be just an example.
|
|
||
| If the input text can be long and place is constrained, use a built-in button to expand the control | ||
| If the input text can be long and the place is constrained, | ||
| use the **Expand** button to expand the control |
There was a problem hiding this comment.
Possibly rewrite the second part of the sentence as "...use an input field with the Expand button". Otherwise, the sentence logic is a bit broken.
|
|
||
| Do **not** use the Show Viewer button instead. | ||
| When the field is expanded, show the **Collapse** button: |
There was a problem hiding this comment.
I think this is the built-in behavior for this control, it will show the Collapse button itself. Possibly just merge this illustration with the previous one, show both default and expanded states nearby, and remove this sentence?
|
|
||
| ### Copy, Info | ||
| To place a button inside a text field, use [`ExtendableTextField`](%gh-ic%/platform/platform-api/src/com/intellij/ui/components/fields/ExtendableTextField.java) and | ||
| its `addExtension()` method. |
There was a problem hiding this comment.
Possibly this part should be in the "Implementation" box at the top like it is for the Split Button?
| To place a button inside a text field, use [`ExtendableTextField`](%gh-ic%/platform/platform-api/src/com/intellij/ui/components/fields/ExtendableTextField.java) and | ||
| its `addExtension()` method. | ||
|
|
||
| The shortcut for a built-in button is <shortcut>Shift+Enter</shortcut>. |
There was a problem hiding this comment.
Possibly add: 1) a subheader "Shortcut", 2) that the shortcut activates only when the input field with the button is focused.
| The only difference is that the selected value is added, instead of overwriting the existing one. | ||
| Place the plus icon inside the control. | ||
| {width=250} | ||
| Place the built-in button inside the input field. Do not place the built-in button next to the field control: |
There was a problem hiding this comment.
The button outside a control is a regular button, not a built-in button. The purpose of the built-in button is to replace this external button and reduce the number of different controls in a dialog, make it more ordered and simple. Possibly move this part under the "When to use" header? This is like a general guideline when to use the built-in button at all — when there's an action to browse, expand, etc. for an input field or a combo box, then don't use a regular button, use a built-in button.
| <table style="none" border="false"> | ||
| <tr> | ||
| <td><format color="369650" style="bold">Correct</format> | ||
| <img src="built_in_button_browse_correct.png" alt="Browse button" width="378"/></td> |
There was a problem hiding this comment.
In the correct example, possibly add a second field with the "list" icon? It would work as a correct example for the button with "..." in the incorrect example
No description provided.