Fix bug in calendar model #763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! |
dima-avdeev-jb
approved these changes
Aug 23, 2023
igordmn
pushed a commit
that referenced
this pull request
Aug 24, 2023
igordmn
pushed a commit
that referenced
this pull request
Jan 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Fixed bug from #717 described in https://kotlinlang.slack.com/archives/CJLTWPH7S/p1692632685323839 (you can reproduce it if you set
TimeZone.setDefault(TimeZone.getTimeZone("GMT-5"))on desktop)getMonthandgetCannonicalDateshould not be converted to local time zone. It should retain UTC (you can see it in legacy impl). The only method that uses system TZ should begetDayOfWeekBy mistake my GMT+3 time zone and time zone on CI somehow passed all the tests copied from android source set. But it was not the case for example for the GMT-5. I apologise for that.
Added non-localized format for desktop instead of ugly skeleton-format without spaces (#717 (comment)) until it properly implemented.
Reordered locale and pattern paremeters for dawin. Locale should be applied before pattern.
Testing
Test: 4 new tests in
KotlinxDatetimeCalendarModelperformed in different time zones