Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add linter ci #61

Merged
merged 9 commits into from
Nov 4, 2024
Merged

add linter ci #61

merged 9 commits into from
Nov 4, 2024

Conversation

baltzell
Copy link
Contributor

@baltzell baltzell commented Nov 1, 2024

No description provided.

@c-dilks
Copy link
Member

c-dilks commented Nov 1, 2024

I tested this in #62, #63, and #64, and in all three cases, the linter catches the issue, but the CI job passes.

Perhaps you'd be better off with for loops here, which (1) print the name of the file, then (2) runs the lint job with proper exit codes

@c-dilks
Copy link
Member

c-dilks commented Nov 1, 2024

Feel free to push commits to those test PRs, and close them when done

@baltzell
Copy link
Contributor Author

baltzell commented Nov 1, 2024

done, all 3 failed after the fix

@c-dilks c-dilks merged commit 48c074b into main Nov 4, 2024
14 of 56 checks passed
@c-dilks c-dilks deleted the linting branch November 4, 2024 22:24
baltzell added a commit that referenced this pull request Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants