Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: use gemc/dev for workflow validation-dev #52

Closed
wants to merge 1 commit into from
Closed

Conversation

c-dilks
Copy link
Member

@c-dilks c-dilks commented Sep 26, 2024

No description provided.

@c-dilks c-dilks marked this pull request as draft September 26, 2024 20:03
@c-dilks
Copy link
Member Author

c-dilks commented Sep 26, 2024

Just changing the ref here doesn't work, we need to modify the GEMC wrapper script in clas12-validation, which is somewhat risky since it might break something else. Let's instead remove validation-dev.

@c-dilks c-dilks closed this Sep 26, 2024
@c-dilks c-dilks deleted the ci-dev-uses-dev branch September 26, 2024 20:43
c-dilks added a commit that referenced this pull request Sep 26, 2024
Removing this workflow, since it would be better if this would test the
`dev` version of GEMC, but that's not straightforward (see #52). Testing
new versions of `gcards` or reconstruction `yamls` should be done in
PRs, rather than `dev/` directories.
baltzell pushed a commit that referenced this pull request Sep 27, 2024
Removing this workflow, since it would be better if this would test the
`dev` version of GEMC, but that's not straightforward (see #52). Testing
new versions of `gcards` or reconstruction `yamls` should be done in
PRs, rather than `dev/` directories.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant