Use ref instead of ReactDOM.findDOMNode() #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReactDOM.findDOMNode() is discouraged, so we use refs instead. This allows us to use this in our server-side render correctly
|
Really neat solution, thanks @gwu |
paranoidjk
reviewed
May 16, 2017
| @@ -126,6 +126,14 @@ var HammerComponent = React.createClass({ | |||
| } | |||
| }, this); | |||
|
|
|||
| var self = this; | |||
| props.ref = function(domElement) { | |||
There was a problem hiding this comment.
@JedWatson @gwu
cc @silentcloud
This PR will cause two problem:
- break change, see below use case, the children's string ref will be override by Hammer
<Hammer
direction="DIRECTION_HORIZONTAL"
onPanStart={this.onPanStart}
onPan={this.onPan}
onPanEnd={this.onPanEnd}
>
<div className={`${prefixCls}-content`} ref="content">
{children}
</div>
</Hammer>- cause react warning: https://facebook.github.io/react/warnings/special-props.html
There was a problem hiding this comment.
+1 Yes this is breaking ref for child components
paranoidjk
referenced
this pull request
in react-component/react-hammerjs
May 16, 2017
moretti
added a commit
to marvelapp/react-hammerjs
that referenced
this pull request
Feb 26, 2018
moretti
added a commit
to marvelapp/react-hammerjs
that referenced
this pull request
Feb 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReactDOM.findDOMNode() is discouraged, so we use refs instead (https://facebook.github.io/react/docs/react-dom.html#finddomnode).
This allows us to use this in our server-side render correctly.