docs: javadocs are now consistent with code, issue #4120 is now fixed.

[DanielSEncora]

Prepare

• [ x] Read PR guidelines
• [ x] Read license information

---

Description

Target issue

Fixing issue #4120 #4120

closes #4120

---

Test and Document the changes

• Static code analysis has been run locally and issues have been fixed
• Relevant unit and integration tests have been added/updated
• Relevant documentation has been updated if any (i.e. user guides, installation and configuration guides, technical design docs etc)

Please check the below before submitting your PR. The PR will not be merged if there are no commits that start with docs: to indicate documentation changes or if the below checklist is not selected.

• [ x] I confirm that there is no impact on the docs due to the code changes in this PR.

[yuriyz]

Is there any reason to comment this line? We don't want to fail build due to javadoc.

[DanielSEncora]

Hi @yuriyz, since the steps to reproduce the issue #4120 were the ones below:

1. Find and comment out false configuration for javadoc plug-in across module pom files
   2.Now run mvn javadoc:javadoc for each module one-by-one"

Once I fixed the documentation inconsistencies I noticed that the application did not fail to build anymore, therefore, I thought that having "false" to counter the build fail was no longer necessary.

[yuriyz]

Understood. This has to be configurable via variable and jenkins job can be configured appropriately. We can't simply enable it and force fail for each and every build.

[DanielSEncora]

Done! Comment has been removed to avoid fail build in my last commit. @yuriyz