prevent use specify datasource name as default in configuration

JakimLi · Mar 4, 2020 · 45fa6d2 · 45fa6d2
1 parent 3846a9c
commit 45fa6d2
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 0 deletions.
diff --git a/...-db/src/main/java/com/github/jakimli/pandaria/configuration/DataSourcesConfiguration.java b/...-db/src/main/java/com/github/jakimli/pandaria/configuration/DataSourcesConfiguration.java
@@ -3,6 +3,7 @@
 import org.springframework.boot.context.properties.ConfigurationProperties;
 import org.springframework.context.annotation.Configuration;
 
+import javax.annotation.PostConstruct;
 import java.util.List;
 import java.util.stream.Collectors;
 import java.util.stream.Stream;

diff --git a/pandaria-db/src/main/java/com/github/jakimli/pandaria/domain/DataSources.java b/pandaria-db/src/main/java/com/github/jakimli/pandaria/domain/DataSources.java
@@ -6,9 +6,11 @@
 import org.springframework.boot.jdbc.DataSourceBuilder;
 import org.springframework.stereotype.Component;
 
+import javax.annotation.PostConstruct;
 import javax.sql.DataSource;
 import java.util.Map;
 
+import static com.github.jakimli.pandaria.configuration.DataSourcesConfiguration.DEFAULT;
 import static com.google.common.collect.Maps.newHashMap;
 
 @Component
@@ -45,4 +47,13 @@ private DataSource buildDataSource(DatasourceProperties property) {
                 .password(property.getPassword())
                 .build();
     }
+
+
+    @PostConstruct
+    public void validateAdditionalDataSourceName() {
+        if (configuration.getAdditional().stream()
+                .anyMatch(property -> DEFAULT.equalsIgnoreCase(property.getName()))) {
+            throw new RuntimeException(String.format("datasource name: '%s' is reserved", DEFAULT));
+        }
+    }
 }