-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BACKLOG-22357: Introduce new tooling to investigate import-package and export-package in the system #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe another ticket for a JUnit Test using mocked FrameworkService will allow to test the OSGIPackageHEaderChecker ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello Kevan, thanks for the PR, nice work !
I just found some minor issues.
src/main/java/org/jahia/modules/tools/gql/admin/ToolsGraphQL.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jahia/modules/tools/gql/admin/osgi/BundleResultEntry.java
Show resolved
Hide resolved
…d export-package in the system (#61) * BACKLOG-22357: Introduce Import-Package checker tool * BACKLOG-22357: Introduce Import-Package checker tool * BACKLOG-22357: Introduce GraphQL API for tooling, and new API to find for export-package * BACKLOG-22357: java doc * BACKLOG-22357: fix GQL naming * BACKLOG-22357: code review fixes
…d export-package in the system (#61) (#65) * BACKLOG-22357: Introduce Import-Package checker tool * BACKLOG-22357: Introduce Import-Package checker tool * BACKLOG-22357: Introduce GraphQL API for tooling, and new API to find for export-package * BACKLOG-22357: java doc * BACKLOG-22357: fix GQL naming * BACKLOG-22357: code review fixes
No description provided.