QA-15066: add unpublish action on vanity urls #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkevan
previously approved these changes
Jul 11, 2024
| @@ -37,13 +37,12 @@ export const Toolbar = ({selection, onChangeSelection, actions}) => { | |||
| actions={actions} | |||
| render={ButtonRenderer} | |||
| filter={action => { | |||
| return action.key !== 'updateVanity'; | |||
| return !['updateVanity', 'unpublish'].includes(action.key); | |||
There was a problem hiding this comment.
Looks dirty to filter action here, since actions are normally based on targets to choose where they should appears or not. But it was already like that before your changes, so I am assuming we can keep this for now.
| }; | ||
|
|
||
| export const atLeastOneLockedForValidation = urls => { | ||
| return urls.some(url => url.default.lockedAndCannotBeEdited && url.default.lockInfo.details.some(detail => detail.type === 'validation')); |
There was a problem hiding this comment.
Should we have undefined protection on this nesting object access ?
jsinovassin
dismissed
jkevan’s stale review
The merge-base changed after approval.
dgriffon
approved these changes
Jul 15, 2024
jsinovassin
added a commit
that referenced
this pull request
Jul 17, 2024
* QA-15066: add unpublish action on vanity urls * fix publication check failing after moving a url
jsinovassin
added a commit
that referenced
this pull request
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.jahia.org/browse/QA-15066