design: Page 병합(로그인 페이지, 2차 페이지) #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alwubin
added
✔︎pull requests
areumH
approved these changes
Aug 12, 2024
WonJuneKim
approved these changes
Aug 12, 2024
| @@ -0,0 +1,67 @@ | |||
| /* eslint-disable jsx-a11y/control-has-associated-label */ | |||
There was a problem hiding this comment.
해당 주석은 어떤 코드에 대해서 lint 를 예외 처리 한 건지 알 수 있을까요?!
There was a problem hiding this comment.
코드를 제가 작성한게 아니라 잘은 모르지만, 하단 소셜 로그인 버튼값을 받아오는데 버튼 안에 텍스트 없이 svg만 있어서 발생하는 eslint인거 같아요.!!
Comment on lines
+29
to
+38
| <Input | ||
| icon={<Envelope />} | ||
| placeholder="이메일" | ||
| style={{ width: '450px' }} | ||
| /> | ||
| <Input | ||
| icon={<Lock />} | ||
| placeholder="비밀번호" | ||
| style={{ width: '450px' }} | ||
| /> |
There was a problem hiding this comment.
input 컴포넌트를 확인해보니 width 관련 css 속성이 없더라구요. 재사용되는 input의 케이스가 한정적이라면 width 역시 스타일을 case 별로 지정해도 좋을거같다고 생각합니다.
There was a problem hiding this comment.
오오 생각하지 못했는데 좋은 생각인거 같아용 ㅎㅎ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💡 작업 내용
💡 자세한 설명
✅ LoginForm
모달 부분을 보다 쉽게 분리하기 위해서
기존에 있던
LoginModal에서LoginForm부분을molecule로 분리하여 구현 후LoginModal에 import하여 사용하였습니다.+) 스토리북에도 추가해두었습니다!
✅ LoginPage, LandingPage, TodayTalkPickPage
Header의 shadowBox 및Footer수정하였는데, 추가적으로 아름님 pr에 맞추었습니다!LandingPage을 제외한 나머지 페이지에 대해서만 추가해주었습니다. 각각/login과/todaytalkpick으로 추가해두었습니다.📗 참고 자료 (선택)
📢 리뷰 요구 사항 (선택)
🚩 후속 작업 (선택)
✅ 셀프 체크리스트
closes #153