.NET Standard support #5

timotei · 2019-10-10T12:29:05Z

Requires first and foremost adding the .NET Standard framework in the NAnt config (netstandard.txt in the root)

Incomplete System.Reflection.Emit: https://github.com/dotnet/coreclr/issues/10199

Also contains some small hacks around Java code depending on .NET-specific code, not available in .NET Standard or extensions

….NET Standard

halex2005

Thanks for great work!

I've taken a look and reviewed some parts of PR.
I hope someone will review this PR too.

halex2005 · 2019-10-22T13:51:06Z

awt/IKVM.AWT.WinForms.8.csproj

@@ -1,159 +1,78 @@
-<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="3.5">
+<Project Sdk="Microsoft.NET.Sdk">


Now when you use new csproj format, I suggest to use PackageReference instead of direct storing nuget packages folder in git.

halex2005 · 2019-10-22T13:53:46Z

ikvmc.8.csproj

  </PropertyGroup>
  <ItemGroup>
    <Reference Include="ICSharpCode.SharpZipLib">
      <Name>ICSharpCode.SharpZipLib</Name>
      <HintPath>bin\ICSharpCode.SharpZipLib.dll</HintPath>
    </Reference>
+    <Reference Include="IKVM.Runtime, Version=0.46.0.5, Culture=neutral, PublicKeyToken=null">


I think that project reference will be better than assembly reference with explicit version specified

halex2005 · 2019-10-22T13:58:03Z

ikvmc/Compiler.cs

@@ -344,6 +346,7 @@ private static void PrintHelp()
 		Console.Error.WriteLine("    -nostdlib                  Do not reference standard libraries");
 		Console.Error.WriteLine("    -lib:<dir>                 Additional directories to search for references");
 		Console.Error.WriteLine("    -noautoserialization       Disable automatic .NET serialization support");
+		Console.Error.WriteLine("    -netstandard       		Generate .NET Standard libraries");


May be useful to mark this line with (default) . Also, here you use two tabs instead of spaces, it may looks ugly in console.

halex2005 · 2019-10-22T14:00:30Z

ikvmc/Compiler.cs

+						if (peer.assembly.Equals(reference, StringComparison.InvariantCultureIgnoreCase))
+						{
+							ArrayAppend(ref target.peerReferences, peer.assembly);
+							goto next_reference;


You may remove ugly goto and get code more readable if you rewrite code with some LINQ.

If I understood your code right, consider something like:

var peerAssemblies = targets .Where(peer => target.unresolvedNetStandardReferences.Contains(peer.assembly, StringComparison.InvariantCultureIgnoreCase)) .ToArray(); foreach (var reference in peerAssemblies) { ArrayAppend(ref target.peerReferences, peer.assembly); } foreach (var reference in target.unresolvedNetStandardReferences.Where(reference => targets.All(peer => !peer.assembly.Equals(reference, StringComparison.InvariantCultureIgnoreCase)))) { int rc = resolver.ResolveReference(cache, ref target.references, reference, true); if (rc != 0) { return rc; } }

halex2005 · 2019-10-22T14:15:13Z

ikvmc/Compiler.cs

+					int rc = resolver.ResolveReference(cache, ref target.references, reference, true);
+					if (rc != 0)
+					{
+						return rc;


I don't like this return statement. Not all peer assemblies could be added to target.peerReferences sometime.

halex2005 · 2019-10-22T14:18:39Z

openjdk/openjdk.build

@@ -8,6 +8,15 @@
        <property name="pathsep" value=";" />
    </if>

+    <target name="all.netstandard">


Actually, I believe we can stop using nant and use something new build script automation tools like cakebuild or nuke. IMO, this will be more readable and supportable.

halex2005 · 2019-10-22T14:19:26Z

openjdk/response.netstandard.txt

+#  [email protected]
+#
+
+assembly.class


Is this file supposed to be included in git history?

halex2005 · 2019-10-22T14:20:55Z

packages.config

@@ -0,0 +1,13 @@
+<?xml version="1.0" encoding="utf-8"?>
+<packages>
+  <package id="Microsoft.Win32.Registry" version="4.5.0" targetFramework="net461" />


I suggest to remove this file and packages folder due to new csproj format is used. We could use PackageReference in csproj instead.

halex2005 · 2019-10-22T14:24:56Z

runtime/CodeEmitter.cs

@@ -1842,7 +1852,11 @@ private void DumpMethod()

 		internal void DefineSymbolDocument(ModuleBuilder module, string url, Guid language, Guid languageVendor, Guid documentType)
 		{
+#if NETSTANDARD
+			throw new PlatformNotSupportedException();


So many potential runtime errors. Could we workaround this sometime?

halex2005 · 2019-10-22T14:27:03Z

runtime/CodeEmitter.cs

@@ -1842,7 +1852,11 @@ private void DumpMethod()

 		internal void DefineSymbolDocument(ModuleBuilder module, string url, Guid language, Guid languageVendor, Guid documentType)
 		{
+#if NETSTANDARD
+			throw new PlatformNotSupportedException();
+#else
 			symbols = module.DefineDocument(url, language, languageVendor, documentType);


May be targeting .net standard 2.1 brings module builder API https://docs.microsoft.com/ru-ru/dotnet/api/system.reflection.emit.modulebuilder

zgramana · 2020-01-17T19:18:26Z

Curious why this excellent work was based on such an old branch as opposed to, say, 8.1?

timotei · 2020-01-19T17:02:10Z

@zgramana Unfortunately we're using this version because trying to use it with Java 8 brings breaking changes (e.g., default implemented method) which we cannot afford right now. However, I might be able to give it a try to apply the changes on a newer branch, but can't promise anything as it's not primary focus.

zgramana · 2020-01-19T19:19:49Z

Interesting. I’ve used this PR as a guide to add support to master. I haven’t completed all of it yet, as I’m torn between replacing csc with exec + dotnet and just using the same approach you took.

I don’t think that I fully understood your comment about Java 8 breaking changes and “default implemented method”. Could you explain that in a little detail?

VincentVk9373 · 2020-01-20T08:38:21Z

We have many dlls compiled from java6-7 on different projects and need them to be compatible together at runtime (dynamic loading). Switching only one of them to java8 means we need to have two different ikvm version at runtime, but also that we need a version of every dlls for both versions, but also that objects cannot be shared between both runtimes.

This was caused indirectly by the way default interfaces methods are handled, which makes interfaces runtime differ, so a class implementing an interface cannot be shared.

timotei added 20 commits July 29, 2019 13:55

Fix compilation on newer .NET versions

66990d4

Update .csproj and .sln for latest VS 2017

ba107da

Use .NET 4.0

2a4959c

Disable PermissionSet-related code on NETSTANDARD

e68acf7

Disable WindowsPreferences on NETSTANDARD

f4106fe

Build IKVM.Runtime first pass with netstandard 2.0

c286ed9

Incomplete System.Reflection.Emit: https://github.com/dotnet/coreclr/issues/10199

Remove AWT build for now

a075aba

Complete the Reflection build

224659a

Compile ikvmc & ikvmstub with .NET 4.6.1

935a09a

Build openjdk against .NET standard libs

5963f50

Also contains some small hacks around Java code depending on .NET-specific code, not available in .NET Standard or extensions

Compile MappedByteBuffer on .NET Standard

bcdc1b5

Compile WindowsPreferences on .NET Standard

3445e6b

Update the IKVM.Runtime first pass run

86e1239

Allow running depcheck against .NET Standard-related libs

17ca836

Get forwarded status when finding type

ee24c18

Generate .NET-standard compatible libraries

01c64a6

Complete the IKVM.Runtime (& JNI) build for .NET Standard

15e900f

Remove AllowPartiallyTrustedCallersAttribute for now, it breaks with …

f4f33cf

….NET Standard

Compile AWT & Swing for .NET Standard

e026c8b

Remove unneeded return type

38de383

halex2005 reviewed Oct 22, 2019

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

.NET Standard support #5

.NET Standard support #5

timotei commented Oct 10, 2019

halex2005 left a comment

halex2005 Oct 22, 2019

halex2005 Oct 22, 2019

halex2005 Oct 22, 2019

halex2005 Oct 22, 2019

halex2005 Oct 22, 2019

halex2005 Oct 22, 2019

halex2005 Oct 22, 2019

halex2005 Oct 22, 2019

halex2005 Oct 22, 2019

halex2005 Oct 22, 2019

halex2005 Oct 22, 2019

zgramana commented Jan 17, 2020

timotei commented Jan 19, 2020

zgramana commented Jan 19, 2020

VincentVk9373 commented Jan 20, 2020

		@@ -1,159 +1,78 @@
		<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="3.5">
		<Project Sdk="Microsoft.NET.Sdk">

.NET Standard support #5

Are you sure you want to change the base?

.NET Standard support #5

Conversation

timotei commented Oct 10, 2019

halex2005 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zgramana commented Jan 17, 2020

timotei commented Jan 19, 2020

zgramana commented Jan 19, 2020

VincentVk9373 commented Jan 20, 2020