Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProjectFileParser can be extracted in a user defined dir #29

Closed
wants to merge 1 commit into from

Conversation

tekuser
Copy link
Contributor

@tekuser tekuser commented Apr 24, 2015

Proposition for Issue #28

@@ -51,6 +51,9 @@ Sample usage:
// overrides project IntermediaryOutputPath
intermediateDir = 'build/msbuild/obj"

// temporary directory where the plugin will extract the project file parser executable
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather avoid making this configurable, it shouldn't be (many gradle plugins download&execute binaries, I've never seen on make the location configurable)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes that makes sense!

@gluck
Copy link
Contributor

gluck commented Apr 24, 2015

Do you know where the std location is for gradle-downloaded-binaries ? I've mostly seen ppl use HOME/.gradle, but not sure it's a standard

@tekuser
Copy link
Contributor Author

tekuser commented Apr 24, 2015

Gradle download dependencies in the user's HOME/.gradle/ (there is a cache inside).
So gradle-msbuild-plugin.jar is downloaded somewhere in HOME/.gradle. But the plugin extract the ProjectFileParser.exe in the user's temp dir (defined by the env var %TEMP% or %TMP%).

So we can do the same thing as in the gradle-nuget-plugin:
https://github.com/Ullink/gradle-nuget-plugin/blob/master/src/main/groovy/com/ullink/BaseNuGet.groovy

l28: File nugetExe = new File(temporaryDir, NUGET_EXE)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants