Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sage10 support #112

Open
wants to merge 33 commits into
base: master
Choose a base branch
from
Open

Sage10 support #112

wants to merge 33 commits into from

Conversation

danlapteacru
Copy link

No description provided.

src/SageFLBuilder.php Outdated Show resolved Hide resolved
src/SageFLBuilder.php Outdated Show resolved Hide resolved
src/Modules/Accordion/Accordion.php Outdated Show resolved Hide resolved
composer.json Show resolved Hide resolved
src/AbstractHelper.php Outdated Show resolved Hide resolved
src/AbstractHelper.php Outdated Show resolved Hide resolved

/** @var AbstractHelper $helper */
$helper = sage(AbstractHelper::class);
$helper = app(AbstractHelper::class);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Redundant? Maybe try making it a blade file.

Copy link
Author

@danlapteacru danlapteacru Jun 15, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codepuncher We will convert all these files into Blade later.

@danlapteacru danlapteacru requested a review from codepuncher June 15, 2020 07:53
@tangrufus
Copy link
Contributor

Remove AbstractHelper if possible. It is technical debt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants