Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

[PIR-142] Log key suffix is isSandboxed is true #69

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

KakeJopulsky
Copy link

@KakeJopulsky KakeJopulsky commented Aug 24, 2022

Status

READY

Jira Ticket(s)

Description

  • The current integration version uses isSandboxed to check if it should use APNS sandbox
  • isSandboxed always returns null, so customers currently trying to register APNS sandbox devices are actually registering devices on APNS prod
  • Updating the integration to use isDebug will correctly allow customers to correctly register APNS sandbox devices
  • See Jira ticket for full context.

The log statement allows us to identify if any customers are passing events where isSandboxed returns true. We can message those customers of the upcoming changes that will remove isSandboxed in favor of isDebug.

Testing

  • Unit tested (including negative cases)
  • Integration tested
  • Manually tested with the staging test tile

@KakeJopulsky KakeJopulsky added bug Something isn't working help wanted Extra attention is needed labels Aug 24, 2022
Copy link

@marlarabin marlarabin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@KakeJopulsky
Copy link
Author

The log appears like this in cloudwatch:
Screen Shot 2022-09-01 at 11 46 42 AM

@KakeJopulsky KakeJopulsky changed the title [PIR-142] Check isDebug during push registration events [PIR-142] Log key suffix is isSandboxed is true Sep 1, 2022
Fix null pointer error in prod due to a user_attribute_list with a null value.
Reject requests with API keys with incorrect length to avoid the extra latency from calling the Iterable API with them.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants