This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
forked from mParticle/firehose-iterable
-
Notifications
You must be signed in to change notification settings - Fork 3
[PIR-142] Log key suffix is isSandboxed is true #69
Open
KakeJopulsky
wants to merge
14
commits into
master
Choose a base branch
from
develop
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[PIR-142] Upgrade mParticle SDK
KakeJopulsky
added
bug
Something isn't working
help wanted
Extra attention is needed
labels
Aug 24, 2022
marlarabin
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
[PIR-142] Update mParticle SDK, logs apiKey suffixes of attempted iOS sandbox device registrants
fix log statement, remove deprecated test
[PIR-142] Logs key suffix if isSandboxed is true
reset sdk to 2.2
KakeJopulsky
changed the title
[PIR-142] Check isDebug during push registration events
[PIR-142] Log key suffix is isSandboxed is true
Sep 1, 2022
Fix null pointer error in prod due to a user_attribute_list with a null value.
Reject requests with API keys with incorrect length to avoid the extra latency from calling the Iterable API with them.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
READY
Jira Ticket(s)
Description
isSandboxed
to check if it should use APNS sandboxisSandboxed
always returns null, so customers currently trying to register APNS sandbox devices are actually registering devices on APNS prodisDebug
will correctly allow customers to correctly register APNS sandbox devicesThe log statement allows us to identify if any customers are passing events where
isSandboxed
returns true. We can message those customers of the upcoming changes that will remove isSandboxed in favor of isDebug.Testing
test
tile