[MOB-10624] add anonymous user id to keychain #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumeruchat
requested changes
Jan 21, 2025
| private boolean encryptionEnforced = false; | ||
| private boolean enableAnonActivation = false; | ||
| private boolean enableEmbeddedMessaging = false; | ||
| private int eventThresholdLimit = 100; | ||
| private IterableIdentityResolution identityResolution = new IterableIdentityResolution(); | ||
| private IterableAnonUserHandler iterableAnonUserHandler; | ||
| private IterableDecryptionFailureHandler decryptionFailureHandler; |
There was a problem hiding this comment.
It is a duplicate. See line 157. I added two by accident in the merge conflict.
There was a problem hiding this comment.
right i didnt notice the one on top my bad
]
| @@ -357,6 +355,8 @@ public Builder setEnableEmbeddedMessaging(boolean enableEmbeddedMessaging) { | |||
|
|
|||
| public Builder setIdentityResolution(IterableIdentityResolution identityResolution) { | |||
| this.identityResolution = identityResolution; | |||
| return this; | |||
There was a problem hiding this comment.
is it necessary to return this?
There was a problem hiding this comment.
Yeah I am just following the other config values. It was deleted when resolving the merge conflicts for some reason.
There was a problem hiding this comment.
makes sense if other config values are also doing it
| } else { | ||
| IterableLogger.w(TAG, "No anon user ID found to migrate.") | ||
| } | ||
|
|
There was a problem hiding this comment.
Since there was no KEY_ANON_USER_ID stored in encrypted shared prefs before we dont need to migrate it either.
There was a problem hiding this comment.
Hm good point I will remove.
added 6 commits
January 22, 2025 09:03
added 2 commits
January 22, 2025 09:28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
✏️ Description