[MOB-10627] removes disable device call #864
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sumeruchat
approved these changes
Jan 17, 2025
sumeruchat
reviewed
Jan 17, 2025
| } else { | ||
| sharedInstance.registerForPush(); | ||
| } | ||
| sharedInstance.registerForPush(); |
There was a problem hiding this comment.
same as iOS when notifications are disabled will android give us a token? If not maybe we have to use the previously registered token and set notificationsEnabled to false with it
There was a problem hiding this comment.
You shouldn't need to OS permissions turned on to get the push token, you just request it from the device. It is given regardless of that setting, the OS setting simply just gates whether or not the device will display the notifications.
There was a problem hiding this comment.
@davidtruong Okay sounds good then. lets test it thoroughly
sumeruchat
reviewed
Jan 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 Jira Ticket(s) if any
✏️ Description