MOB-10364 Support for In App JSON Only Messages #857
Conversation
sumeruchat
changed the base branch from
master
to
feature/MOB-10521-prepare-3.5.6-release
sumeruchat
changed the title
| @@ -414,7 +419,8 @@ private void processMessages() { | |||
| InAppResponse response = handler.onNewInApp(message); | |||
| IterableLogger.d(TAG, "Response: " + response); | |||
| message.setProcessed(true); | |||
| if (response == InAppResponse.SHOW) { | |||
|
|
|||
| if (response == InAppResponse.SHOW || message.isJsonOnly()) { | |||
There was a problem hiding this comment.
@sumeruchat I might be mis-reading this, but should this be !message.isJsonOnly() here?
There was a problem hiding this comment.
Ah, it looks like showMessage immediately discards it. Sorry for the noise.
There was a problem hiding this comment.
Well, circling back — why pass it to showMessage?
There was a problem hiding this comment.
This line means we "show" the message and ignore whatever the return value from onNew was. In the showMessage method we will just simply consume jsonOnly messages without actually showing them. I agree it looks like a mistake should I try to do it differently?
There was a problem hiding this comment.
I'll think about it and change this just for clarity later.
There was a problem hiding this comment.
Sounds good. This isn't a big deal — feel free to leave it if you think that's best! Maybe just a comment?
| setRead(message, true, null, null); | ||
| message.setConsumed(true); | ||
| return; | ||
| } |
There was a problem hiding this comment.
@bradumbaugh here we will make sure we dont actually "show" jsonOnly messages
|
|
||
| message.inAppStorageInterface = storageInterface; | ||
| if (html != null) { | ||
| if (content.html != null && content.html.length() > 0 && !jsonOnly) { |
There was a problem hiding this comment.
This was suggested to be replaced with !content.html.isEmpty()
iterableapi/src/test/java/com/iterable/iterableapi/IterableInAppManagerTest.java
Outdated
Show resolved
Hide resolved
🔹 Jira Ticket(s) if any
✏️ Description
Support for JSON Only in app messages