[MOB-9235] ANR Prevention by migrating data from encrypted to shared prefs and discontinue use of encrypted shared prefs #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
sumeruchat
force-pushed
the
feature/MOB-9235-ANR-EncryptedSharedPrefs
branch
from
3412df8 to
c292958
Compare
evantk91
approved these changes
Dec 27, 2024
| // Only attempt migration on Android M and above | ||
| if (Build.VERSION.SDK_INT < Build.VERSION_CODES.M) { | ||
| markMigrationCompleted() | ||
| migrationCompletionCallback?.invoke(null) |
There was a problem hiding this comment.
What do we do for android versions less than M? Is migration off of encrypted shared preference not required?
There was a problem hiding this comment.
Since we did not try to have encrypted shared preferences on our older keychain in versions less than M we dont need to migrate either
There was a problem hiding this comment.
but it is a good point if we should migrate from normal shared preferences in those versions
There was a problem hiding this comment.
I have added support for this now
iterableapi/src/test/java/com/iterable/iterableapi/IterableDataEncryptorTest.java
Show resolved
Hide resolved
evantk91
reviewed
Dec 27, 2024
| } | ||
|
|
||
| @Test | ||
| public void testSkipIfBelowAndroidM() { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… shared prefs
🔹 Jira Ticket(s) if any
✏️ Description
To prevent ANRs we are migrating data from encrypted to shared prefs and discontinue use of encrypted shared prefs