Performance/placeholders #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boiscljo
commented
May 13, 2024
boiscljo
commented
May 13, 2024
plugin/src/main/java/com/iridium/iridiumcore/utils/Placeholder.java
Outdated
Show resolved
Hide resolved
boiscljo
commented
May 14, 2024
| @@ -11,8 +13,10 @@ | |||
| public class Placeholder { | |||
|
|
|||
| private final String key; | |||
There was a problem hiding this comment.
Semi breaking change, nothing should reference the key directly, but key is without percent signs, formattedKey is with signs
|
@boiscljo I'm sorry, I don't understand pretty much PR but, I saw the code (from 2 PR that you made) and it's seems that it can improve the performance. Please go on to push this asap beucase I have a large network that is lagging a lot because of that. I appreciate too much! |
PeachesMLG
reviewed
May 19, 2024
Comment on lines
58
to
+59
| if(value==null && supplier!=null) value = supplier.get(); | ||
| return value; | ||
| return value; |
There was a problem hiding this comment.
There is a case where both value and supplier can be null here now no? Is this an issue?
There was a problem hiding this comment.
It's an issue with normal placeholder it will just return null without throwing
PeachesMLG
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.