-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitVersion-yaml change #50
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughThe pull request modifies the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
GitVersion.yml (2)
14-14
: Fix trailing whitespaceRemove the trailing space at the end of line 14.
- is-release-branch: true + is-release-branch: true🧰 Tools
🪛 yamllint (1.35.1)
[error] 14-14: trailing spaces
(trailing-spaces)
🪛 GitHub Actions: CI Build
[error] Invalid configuration: Property 'tag' not found on type 'GitVersion.Configuration.BranchConfiguration'. Configuration file format is incorrect.
9-14
: Consider version increment strategy for hotfixesThe configuration doesn't specify an increment strategy for hotfix branches. Consider whether hotfixes should always increment the patch version.
You might want to add:
hotfix: regex: hotfix[/-] source-branches: [develop] + increment: Patch prevent-increment: when-current-commit-tagged: true is-release-branch: true
🧰 Tools
🪛 yamllint (1.35.1)
[error] 14-14: trailing spaces
(trailing-spaces)
🪛 GitHub Actions: CI Build
[error] Invalid configuration: Property 'tag' not found on type 'GitVersion.Configuration.BranchConfiguration'. Configuration file format is incorrect.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
GitVersion.yml
(1 hunks)
🧰 Additional context used
🪛 yamllint (1.35.1)
GitVersion.yml
[error] 14-14: trailing spaces
(trailing-spaces)
🪛 GitHub Actions: CI Build
GitVersion.yml
[error] Invalid configuration: Property 'tag' not found on type 'GitVersion.Configuration.BranchConfiguration'. Configuration file format is incorrect.
🔇 Additional comments (1)
GitVersion.yml (1)
11-11
: Review source branch configurationCurrently, hotfix branches are configured to branch from
develop
. In standard GitFlow, hotfixes typically branch frommain
/master
as they're meant to patch production issues.Let's verify the branching strategy:
Consider updating the source branch configuration if this doesn't align with your branching strategy.
🧰 Tools
🪛 GitHub Actions: CI Build
[error] Invalid configuration: Property 'tag' not found on type 'GitVersion.Configuration.BranchConfiguration'. Configuration file format is incorrect.
…Gurus/netcore.utilities into bug/gitversion-yaml
|
Summary by CodeRabbit
tag
property withlabel
fordevelop
andpull-request
branchespull-request
branch