Strip parameter to encoders that support exif #1420
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deluxetom
referenced
this pull request
in Intervention/image-driver-vips
Jan 18, 2025
olivervogel
reviewed
Jan 18, 2025
olivervogel
reviewed
Jan 18, 2025
| @@ -37,4 +37,17 @@ public function testEncodeProgressive(): void | |||
| $this->assertEquals('image/jpeg', $result->mimetype()); | |||
| $this->assertTrue($this->isProgressiveJpeg($result)); | |||
| } | |||
|
|
|||
| public function testEncodeStripExif(): void | |||
There was a problem hiding this comment.
The GD thing is tricky. There is no real function to delete meta data, but it is possible to create a new GDImage object and copy the data into it. The metadata is not transferred.
However, this does not lead to a consistent result. As the copy action described is used at various points in modifiers in order to achieve different results.
- src/Drivers/Gd/Modifiers/RotateModifier.php:83
- src/Drivers/Gd/Modifiers/ContainModifier.php:53
- src/Drivers/Gd/Modifiers/QuantizeColorsModifier.php:45
- src/Drivers/Gd/Modifiers/BlendTransparencyModifier.php:25
- src/Drivers/Gd/Modifiers/CropModifier.php:46
- src/Drivers/Gd/Modifiers/ResizeModifier.php:40
- src/Drivers/Gd/Modifiers/CoverModifier.php:40
Basically, the metadata is (almost) always lost with GD and Intervention Image, even if this is not desired. :( This is also the reason why I have not yet integrated a “strip” feature.
There was a problem hiding this comment.
Metadata is apparently not taken into account at all with GD.
$data = fopen('php://temp', 'r+');
$img = imagecreatefromjpeg('exif.jpg'); // decode
imagejpeg($img, $data); // encode
$exif = exif_read_data($data); // exif gone
|
I have developed this further here: #1421 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work in progress