Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set forceLegacyOverBrightClamping #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

slipher
Copy link

@slipher slipher commented Apr 14, 2024

The map generally looks worse with the newly enabled full overbright implementation. A lot of lights seem too bright. Lighting of models in the alien base is especially bad: the Overmind is bright despite being in a dark corner and an egg looks as if under bright sunlight.
unvanquished_2024-04-03_165313_000

unvanquished_2024-04-03_165320_000

The map generally looks worse with the newly enabled full overbright
implementation. A lot of lights seem too bright. Lighting of models in
the alien base is especially bad: the Overmind is bright despite being
in a dark corner and an egg looks as if under bright sunlight.
@illwieckz
Copy link
Member

illwieckz commented Apr 14, 2024

The overmind being bright is because of the limitations of lightgrid. Relying on bugs to workaround lightgrid design limitations is not good.

I disagree with “The map generally looks worse with the newly enabled full overbright implementation”.

I toyed today with this map while experimenting with automatic specular map emulation as fallback for maps missing them, and I was very happy with the map having correct lighting. This becomes even more true when enabling specularirty since deluxe mapping is wrong when light is clamped.

@illwieckz
Copy link
Member

Also if we find the light too bright, we better want to use a lower overbright factor and rebuild the map than clamping the light.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants