db-synthesizer: relax check whether a dir "looks like a ChainDB" #1221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See the PR description
amesgen
requested review from
nfrisby,
jasagredo,
fraser-iohk,
dnadales and
RenateEilers
as code owners
dnadales
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
db-synthesizer has a sanity check when (over)writing a directory to check whether it actually plausibly contains a ChainDB. Previously, this check was only succeeding when the directory would contain exactly three entries named
immutable/ledger/volatile. This is somewhat annoying, as ChainDBs usually contain the foldergsmas well as files likeclean/lock/protocolMagicIdin addition.This PR relaxes the check, as discussed with @mgmeier: We now only check whether the subdirectories are a subset of
immutable/ledger/volatile/gsm, and fail if any other subdirectories are present.Follow-up to #1206