db-analyser: support reapplication in --benchmark-ledger-ops
#1219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amesgen
requested review from
nfrisby,
jasagredo,
fraser-iohk,
dnadales and
RenateEilers
as code owners
amesgen
commented
Aug 16, 2024
ouroboros-consensus-cardano/src/unstable-cardano-tools/Cardano/Tools/DBAnalyser/Analysis.hs
Show resolved
Hide resolved
dnadales
approved these changes
Aug 16, 2024
amesgen
force-pushed
the
amesgen/db-analyser-ledger-ops-reapply
branch
from
5357e48 to
b7c079a
Compare
In a later commit, this is useful to avoid cyclic imports when adding new types to `.Types` that are also used in other modules.
amesgen
force-pushed
the
amesgen/db-analyser-ledger-ops-reapply
branch
from
b7c079a to
2f3ace3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit is just boring refactoring.