-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add overview of the tasks of a caught-up node #1215
Conversation
5c30a4f
to
0572d0b
Compare
0572d0b
to
75dfc10
Compare
VolatileDB --> CopyToImmutableDB | ||
CopyToImmutableDB --> ImmutableDB | ||
GarbageCollect -- "cleans up" --> VolatileDB | ||
LedgerDB --> CreateLedgerSnapshot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like it is aligned with the ImmutableDB, but it should be aligned with the volatiledb. Maybe it is not possible with mermaid?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I don't think Mermaid has enough flexibility for stuff like this. Maybe it is possible to do sth with invisible arrows, but I don't think it is too terrible.
75dfc10
to
0b3adba
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry for the delay! I hadn't realized I didn't send my first review pass. I've now read the whole thing.
|
||
7. In parallel, chain selection for B continues by validating B. | ||
|
||
Time budget: average ~30ms, upper bound ~500ms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where does 500ms
come from? EG the June attack exceeded this -- what's the scope being considered here? Perhaps it's none-buggy-block validation 😬
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing that out, I chose that number somewhat arbitrarily. According to the recent db-analyser pass, there are only 1596 blocks with block application mutator time higher than 500ms, out of which 1574 (all but 22 blocks) are due to the ref script DoS.
I added a "based on empirical data" caveat.
0b3adba
to
e290eed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really helpful. Thank you for taking the time to write this up 🫶
e290eed
to
d594504
Compare
d594504
to
562071e
Compare
Closes #1057