reduce the frequency of client and server diverging before they reach startTick #1201
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the generator for
ChainSyncClientSetup
such thatstartTick
is now heavily weighted to pick a lower value (closer to 1) rather than a linear range between 1 andmaxStartTick
. This causes fewer randomly-generatedChainSyncClientSetup
s to produce test runs in which no headers are sent due to immediate divergence.Before:
After:
Note that the
NoMoreIntersection
case is now significantly more common than theForkTooDeep
case, rather than the inverse.Closes #529