Plutus script purpose #3960
Merged
Plutus script purpose #3960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
lehins
force-pushed
the
lehins/plutus-script-purpose
branch
6 times, most recently
from
09067e7 to
ffbc90d
Compare
lehins
force-pushed
the
lehins/plutus-script-purpose
branch
from
ffbc90d to
846e660
Compare
lehins
force-pushed
the
lehins/plutus-script-purpose
branch
3 times, most recently
from
f7aeba6 to
5c909cf
Compare
Soupstraw
reviewed
Jan 16, 2024
lehins
force-pushed
the
lehins/plutus-script-purpose
branch
from
5c909cf to
6d97b11
Compare
aniketd
reviewed
Jan 16, 2024
Soupstraw
reviewed
Jan 16, 2024
lehins
force-pushed
the
lehins/plutus-script-purpose
branch
from
6d97b11 to
5fccd5a
Compare
ScriptPurpuse and RdmrPtr are very much related concepts. This commit replaces them with a single type family that is parametric on the era and on the type that does the selection whether it is a plutus script purpose or it is a redeemer pointer. Those types are called `AsItem` and `AsIndex` respectively. Besides making plutus script purpose parametric this commit also introduces new purposes for Conway: `Voting` and `Proposing`
lehins
force-pushed
the
lehins/plutus-script-purpose
branch
from
5fccd5a to
d223ee4
Compare
lehins
added a commit
that referenced
this pull request
Mar 2, 2024
Unfortunately we can't fix this problem for Babbage era, because that would break the node-to-client protocol. So, we need to wait until we are in Conway to fix this serialization issue with `PlutusPurpose`. With respect to fixing this problem for Conway, this is already done. It has been fixed with introduction of `ConwayPlutusPurpose` type in #3960
lehins
added a commit
that referenced
this pull request
Mar 2, 2024
Unfortunately we can't fix this problem for Babbage era, because that would break the node-to-client protocol. So, we need to wait until we are in Conway to fix this serialization issue with `PlutusPurpose`. With respect to fixing this problem for Conway, this is already done. It has been fixed with introduction of `ConwayPlutusPurpose` type in #3960
lehins
added a commit
that referenced
this pull request
Mar 4, 2024
Unfortunately we can't fix this problem for Babbage era, because that would break the node-to-client protocol. So, we need to wait until we are in Conway to fix this serialization issue with `PlutusPurpose`. With respect to fixing this problem for Conway, this is already done. It has been fixed with introduction of `ConwayPlutusPurpose` type in #3960
lehins
added a commit
that referenced
this pull request
Mar 4, 2024
Unfortunately we can't fix this problem for Babbage era, because that would break the node-to-client protocol. So, we need to wait until we are in Conway to fix this serialization issue with `PlutusPurpose`. With respect to fixing this problem for Conway, this is already done. It has been fixed with introduction of `ConwayPlutusPurpose` type in #3960
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3663
Fixes #3533
Introduce PlutusPurpose:
ScriptPurpuse and RdmrPtr are very much related concepts. This commit
replaces them with a single type family that is parametric on the era
and on the type that does the selection whether it is a plutus script
purpose or it is a redeemer pointer. Those types are called
AsItemandAsIndexrespectively.Besides making plutus script purpose parametric this commit also
introduces new purposes for Conway:
VotingandProposingChecklist
.cabalandCHANGELOG.mdfiles according to theversioning process.
.cabalfiles for all affected packages are updated. If you change the bounds in a cabal file, that package itself must have a version increase. (See RELEASING.md)CHANGELOG.mdfor the affected packages. New section is never added with the code changes. (See RELEASING.md)fourmolu(usescripts/fourmolize.sh)scripts/cabal-format.sh)hie.yamlhas been updated (usescripts/gen-hie.sh)