Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-testnet-data: move Byron handling to its own file #992

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

smelc
Copy link
Contributor

@smelc smelc commented Dec 11, 2024

Changelog

- description: |
    create-testnet-data: move Byron handling to its own file
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

How to trust this PR

This is just code moved around: no functional change.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • Self-reviewed the diff

Copy link
Contributor

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@smelc smelc force-pushed the smelc/create-testnet-data-byron-ostracism branch from 5d7b874 to 723da98 Compare December 12, 2024 08:57
@smelc smelc enabled auto-merge December 12, 2024 08:57
@smelc smelc added this pull request to the merge queue Dec 12, 2024
Merged via the queue into master with commit e68b762 Dec 12, 2024
25 checks passed
@smelc smelc deleted the smelc/create-testnet-data-byron-ostracism branch December 12, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

create-testnet-data: Follow-up of byron genesis creation
2 participants