create-testnet-data's implementation: explain why drepDelegs can be left empty #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smelc
requested review from
Jimbo4350,
newhoggy,
carbolymer,
palas,
kevinhammond and
disassembler
as code owners
palas
approved these changes
Dec 11, 2024
cardano-cli/src/Cardano/CLI/EraBased/Run/Genesis/CreateTestnetData.hs
Outdated
Show resolved
Hide resolved
smelc
force-pushed
the
smelc/create-testnet-data-explain-drepDelegs-being-empty
branch
from
8fb4b87 to
de15cc7
Compare
smelc
force-pushed
the
smelc/create-testnet-data-explain-drepDelegs-being-empty
branch
from
de15cc7 to
a12df9d
Compare
smelc
deleted the
smelc/create-testnet-data-explain-drepDelegs-being-empty
branch
Jimbo4350
reviewed
Jan 2, 2025
| @@ -516,7 +516,9 @@ runGenesisCreateTestNetDataCmd | |||
| { L.drepExpiry = EpochNo 1_000 | |||
| , L.drepAnchor = SNothing | |||
| , L.drepDeposit = max (L.Coin 1_000_000) minDeposit | |||
| , L.drepDelegs = Set.empty | |||
| , L.drepDelegs = Set.empty -- We don't need to populate this field (field "initialDReps"."keyHash-*"."delegators" in the JSON) | |||
There was a problem hiding this comment.
Can you add the actual explanation from Alexy here and also confirm if the `"delegators" field will be removed?
Linking to the actual issue would be better: IntersectMBO/cardano-ledger#4782 (comment)
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Document with a comment why #987 is not required
How to trust this PR
It's comments only
Checklist