Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add golden tests for --drep-key-hash in governance drep #453

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

mkoura
Copy link
Contributor

@mkoura mkoura commented Nov 14, 2023

Changelog

- description: |
    Add golden tests for `--drep-key-hash` in `governance drep`
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - improvement    # QoL changes e.g. refactoring
  # - bugfix         # fixes a defect
  - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Additional context for the PR goes here. If the PR fixes a particular issue please provide a link to the issue.

How to trust this PR

Highlight important bits of the PR that will make the review faster. If there are commands the reviewer can run to observe the new behavior, describe them.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@mkoura mkoura force-pushed the drep_key_hash_golden branch from 6a81df0 to ded3b06 Compare November 14, 2023 12:14
@mkoura mkoura force-pushed the drep_key_hash_golden branch from ded3b06 to 81e40cb Compare November 14, 2023 12:32
@mkoura mkoura force-pushed the drep_key_hash_golden branch from 81e40cb to 86337a6 Compare November 14, 2023 12:56
@mkoura mkoura added this pull request to the merge queue Nov 14, 2023
Merged via the queue into main with commit 7082071 Nov 14, 2023
@mkoura mkoura deleted the drep_key_hash_golden branch November 14, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants