Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor node connection passing to make it use LocalNodeConnectInfo type #1034

Merged

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Jan 28, 2025

Changelog

- description: |
    Refactor node connection passing to make it use `LocalNodeConnectInfo` type
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
   - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
  # - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

This is just a compatible refactoring to reduce boilerplate. LocalNodeConnectInfo is now used for carrying node connection info, instead of three separate fields.

The change in golden files, is just a change of the order where --socket-path appears in CLI help.

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

@carbolymer carbolymer force-pushed the mgalazyn/chore/refactor-node-connection-info-passing branch 2 times, most recently from 916c442 to ef697f8 Compare January 28, 2025 15:02
@carbolymer carbolymer changed the title Refactor node connection passing Refactor node connection passing to make it use LocalNodeConnectInfo type Jan 28, 2025
@carbolymer carbolymer marked this pull request as ready for review January 28, 2025 15:03
@carbolymer carbolymer marked this pull request as draft January 28, 2025 15:06
@carbolymer carbolymer force-pushed the mgalazyn/chore/refactor-node-connection-info-passing branch from 1c32c7d to 98d8b26 Compare January 28, 2025 15:09
@carbolymer carbolymer marked this pull request as ready for review January 28, 2025 15:09
Copy link
Contributor

@smelc smelc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

cardano-cli/src/Cardano/CLI/Orphans.hs Outdated Show resolved Hide resolved
@carbolymer carbolymer force-pushed the mgalazyn/chore/refactor-node-connection-info-passing branch from 98d8b26 to 8a42ee4 Compare January 29, 2025 15:22
@carbolymer carbolymer enabled auto-merge January 29, 2025 15:22
@carbolymer carbolymer disabled auto-merge January 29, 2025 15:22
@carbolymer carbolymer enabled auto-merge January 29, 2025 15:22
@carbolymer carbolymer force-pushed the mgalazyn/chore/refactor-node-connection-info-passing branch from 8a42ee4 to 0aba300 Compare January 29, 2025 15:23
@carbolymer carbolymer force-pushed the mgalazyn/chore/refactor-node-connection-info-passing branch from 0aba300 to 2b3f721 Compare January 29, 2025 15:43
@carbolymer carbolymer disabled auto-merge January 29, 2025 16:05
@carbolymer carbolymer merged commit 02a2bca into master Jan 29, 2025
20 of 25 checks passed
@carbolymer carbolymer deleted the mgalazyn/chore/refactor-node-connection-info-passing branch January 29, 2025 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants