Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify GHAs using nix, update nix shell haskell tools #1029

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented Jan 23, 2025

Changelog

- description: |
    Simplify GHA using nix, update nix shell haskell tools
# uncomment types applicable to the change:
  type:
  # - feature        # introduces a new feature
  # - breaking       # the API has changed in a breaking way
  # - compatible     # the API has changed but is non-breaking
  # - optimisation   # measurable performance improvements
  # - refactoring    # QoL changes
  # - bugfix         # fixes a defect
  # - test           # fixes/modifies tests
   - maintenance    # not directly related to the code
  # - release        # related to a new release preparation
  # - documentation  # change in code docs, haddocks...

Context

Simplify GHAs using nix, update nix shell haskell tools:

  • HLS 2.9
  • ghcid 0.8.9
  • fourmolu 0.17

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. See Running tests for more details
  • Self-reviewed the diff

flake.nix Show resolved Hide resolved
flake.nix Outdated Show resolved Hide resolved
@carbolymer carbolymer force-pushed the mgalazyn/chore/update-nix-build-tools branch 4 times, most recently from 907bc52 to 31b63c5 Compare January 24, 2025 10:39
@carbolymer carbolymer force-pushed the mgalazyn/chore/update-nix-build-tools branch 6 times, most recently from cd14191 to 489886e Compare January 28, 2025 15:24
@carbolymer carbolymer changed the title Update nix build tools Simplify GHA using nix, update nix shell haskell tools Jan 28, 2025
@carbolymer carbolymer changed the title Simplify GHA using nix, update nix shell haskell tools Simplify GHAs using nix, update nix shell haskell tools Jan 28, 2025
@carbolymer carbolymer force-pushed the mgalazyn/chore/update-nix-build-tools branch 2 times, most recently from cf2ec4d to 759d7fd Compare January 28, 2025 16:18
@carbolymer carbolymer marked this pull request as ready for review January 28, 2025 16:18
@carbolymer carbolymer requested review from a team as code owners January 28, 2025 16:18
@carbolymer carbolymer force-pushed the mgalazyn/chore/update-nix-build-tools branch 2 times, most recently from e10ffab to 01ce1af Compare January 28, 2025 16:21
- name: Run cabal-gild over all modified files
run: |
rc="0"
echo "cabal-gild version: ${{env.CABAL_GILD_VERSION}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is the CABAL_GILD_VERSION env variable defined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

.github/workflows/actionlint.yml Show resolved Hide resolved
- name: Run cabal-gild over all modified files
run: |
rc="0"
echo "cabal-gild version: ${{env.CABAL_GILD_VERSION}}"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
echo "cabal-gild version: ${{env.CABAL_GILD_VERSION}}"
echo "cabal-gild version: $(cabal-gild --version)"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

.github/workflows/github-page.yml Outdated Show resolved Hide resolved
cabal update

- name: Build whole project
run: |
nix develop .\#haddockShell --command \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 💯

@carbolymer carbolymer force-pushed the mgalazyn/chore/update-nix-build-tools branch from 76badbe to 5ff4a1b Compare January 29, 2025 15:49
@carbolymer carbolymer force-pushed the mgalazyn/chore/update-nix-build-tools branch from 5ff4a1b to c784eb2 Compare January 29, 2025 15:50
@carbolymer carbolymer merged commit 9b10c78 into master Jan 29, 2025
11 checks passed
@carbolymer carbolymer deleted the mgalazyn/chore/update-nix-build-tools branch January 29, 2025 15:51
@carbolymer carbolymer self-assigned this Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants