-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add governance action deposits to stake-address-info query #1024
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosLopezDeLara
requested review from
Jimbo4350,
newhoggy,
carbolymer,
smelc,
palas,
kevinhammond and
disassembler
as code owners
January 17, 2025 16:53
carbolymer
requested changes
Jan 17, 2025
Jimbo4350
reviewed
Jan 20, 2025
CarlosLopezDeLara
force-pushed
the
cl/sai
branch
from
January 22, 2025 15:51
d8ea0e2
to
c40f1e3
Compare
* Added reference test for `compatible conway transaction singed-transaction`
removing all use of the ScriptWitnessFiles type
…d CliSpendScriptRequirements
therefore we can remove the ShelleyBasedEra era parameter Notice that as a result of factoring out the spending script witness related code we have gained a simplification i.e we no longer have to pollute several functions with the ShelleyBasedEra era parameter
WitCtxStake in compatibility transaction build command
Comment on lines
+2038
to
+2043
<*> ( optional | ||
( pPlutusReferenceSpendScriptWitness balance | ||
<|> pSimpleReferenceSpendingScriptWitess | ||
<|> pOnDiskSimpleOrPlutusScriptWitness | ||
) | ||
) |
Check notice
Code scanning / HLint
Redundant bracket Note
cardano-cli/src/Cardano/CLI/EraBased/Options/Common.hs:(2038,9)-(2043,9): Suggestion: Redundant bracket
Found:
(,)
<$>
Opt.option
(readerFromParsecParser parseTxIn)
(Opt.long "tx-in" <> Opt.metavar "TX-IN" <> Opt.help "TxId#TxIx")
<>
(optional
(pPlutusReferenceSpendScriptWitness balance
<|> pSimpleReferenceSpendingScriptWitess
<|> pOnDiskSimpleOrPlutusScriptWitness))
Perhaps:
(,)
<$>
Opt.option
(readerFromParsecParser parseTxIn)
(Opt.long "tx-in" <> Opt.metavar "TX-IN" <> Opt.help "TxId#TxIx")
<>
optional
(pPlutusReferenceSpendScriptWitness balance
<|> pSimpleReferenceSpendingScriptWitess
<|> pOnDiskSimpleOrPlutusScriptWitness)
Found:
(,)
<$>
Opt.option
(readerFromParsecParser parseTxIn)
(Opt.long "tx-in" <> Opt.metavar "TX-IN" <> Opt.help "TxId#TxIx")
<>
(optional
(pPlutusReferenceSpendScriptWitness balance
<|> pSimpleReferenceSpendingScriptWitess
<|> pOnDiskSimpleOrPlutusScriptWitness))
Perhaps:
(,)
<$>
Opt.option
(readerFromParsecParser parseTxIn)
(Opt.long "tx-in" <> Opt.metavar "TX-IN" <> Opt.help "TxId#TxIx")
<>
optional
(pPlutusReferenceSpendScriptWitness balance
<|> pSimpleReferenceSpendingScriptWitess
<|> pOnDiskSimpleOrPlutusScriptWitness)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog
Context
Resolves #954
Requires IntersectMBO/cardano-api#730
How to trust this PR
The query now includes a map of (GovActionIds, Deposit) assocoated to the stake address:
or empty if it is not associated to any
BABBAGE: With the latest chantes the query still works in Babbage era:
Checklist