Add function collectPlutusScriptHashes to collect script hashes needed to validate a given transaction

[palas]

Changelog

- description: |
    Add function `collectPlutusScriptHashes` to collect script hashes needed to validate a given transaction
  type:
  - feature

Context

This is required functionality by this cardano-cli PR: IntersectMBO/cardano-cli#1031

How to trust this PR

Ensure the API is in the correct place and has the right structure, that it does the right thing, that the documentation is adequate. Also check in conjunction with the related PRs:

• cardano-node: cardano-testnet: Test plutus script cost calculation command cardano-node#6097
• cardano-cli: Add command to calculate plutus script costs from an already constructed transaction cardano-cli#1031

Checklist

• Commit sequence broadly makes sense and commits have useful messages
• New tests are added if needed and existing tests are updated. See Running tests for more details
• Self-reviewed the diff

[carbolymer]

This function is more related to TxBody rather than to this module, so it should go to Cardano.Api.Tx.Body I think.

(Cardano.Api.Tx.Body should get chopped down into smaller modules, but that's a separate discussion...)

[palas]

I tried but it generated a cyclic dependency. It would probably be solvable by creating some Type modules and moving stuff around, but it was not trivial at all

[carbolymer]

Ok lets leave it for now. 👍🏻

[Jimbo4350]

I would parameterize this on a the api's Tx era. TxBody era will be removed in the future because it is a poor abstraction. It (unsuccessfully) tries to find a middle ground between a full transaction and a tx body as defined in the ledger.

[palas]

Backported branch: https://github.com/IntersectMBO/cardano-api/tree/plutus-script-cost-calculation-cmd-backport

[Jimbo4350]

Before this is merged and exposed I want to have a crack at where this is called in cardano-cli.

[Jimbo4350]

LGTM but one comment needs to be addressed.

[Jimbo4350]

I would parameterize this on a the api's Tx era. TxBody era will be removed in the future because it is a poor abstraction. It (unsuccessfully) tries to find a middle ground between a full transaction and a tx body as defined in the ledger.

[palas]

I would parameterize this on a the api's Tx era. TxBody era will be removed in the future because it is a poor abstraction. It (unsuccessfully) tries to find a middle ground between a full transaction and a tx body as defined in the ledger.

Addressed here: 6e17447